Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to QueryItemDescription #330

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Updates to QueryItemDescription #330

merged 4 commits into from
Aug 9, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Aug 8, 2024 •
edited
Loading

Description

Please view by commit.

  • Add additional validations to QueryItemDescription
  • Rename QueryItemDescription -> ObjectBuilderItemDescription (and similar)
  • Add tests for valid and invalid cases.

Checklist

@cla-bot cla-bot bot added the cla:yes label Aug 8, 2024
@plypaul plypaul force-pushed the plypaul--66--refine-query-item branch from b49e47b to 0cdd489 Compare August 8, 2024 22:31
@plypaul plypaul marked this pull request as ready for review August 8, 2024 22:37
@plypaul plypaul requested review from QMalcolm, graciegoheen and a team as code owners August 8, 2024 22:37
DevonFulcher
DevonFulcher approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@DevonFulcher DevonFulcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@plypaul plypaul merged commit 42bbe3b into main Aug 9, 2024
82 checks passed
@plypaul plypaul deleted the plypaul--66--refine-query-item branch August 9, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DevonFulcher DevonFulcher DevonFulcher approved these changes

@QMalcolm QMalcolm Awaiting requested review from QMalcolm QMalcolm is a code owner

@graciegoheen graciegoheen Awaiting requested review from graciegoheen graciegoheen is a code owner

Assignees
No one assigned
Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plypaul @DevonFulcher